Re: [Qemu-devel] [PATCH v12 0/4] support to migrate with IPv6 address

[Michael Roth]

On Thu, May 10, 2012 at 11:29:48AM -0600, Eric Blake wrote:
> On 05/10/2012 10:27 AM, Amos Kong wrote:
> > Those patches updated help functions in qemu-socket.c,
> > and used them in migrate-tcp.c to supporting IPv6 migration.
> > 
> 
> > ---
> > 
> > Amos Kong (4):
> >       qerror: add five qerror strings
> >       sockets: change inet_connect() to support nonblock socket
> >       sockets: use error class to pass listen error
> >       use inet_listen()/inet_connect() to support ipv6 migration
> 
> I'm trying to understand the scope of this series, and how it might
> impact what libvirt needs to support for migration in an IPv6
> environment.  Is the point of this patch that IPv6 migration was
> previously not possible, and is now possible using [IP6addr]:port notation?

Looks like Amos went offline: but yes, in a nutshell.

addr parsing now relies on qemu-sockets.c:inet_parse(), which has supported
[ip6addr]:port for a while, as opposed to net.c:parse_host_port(), which
didn't.

Additional Error-handling was added to
qemu-sockets.c:inet_connect()/inet_listen(), along with non-blocking support
for inet_connect(), to subsume the ad-hoc client/server setup in
migration-tcp.c

> 
> -- 
> Eric Blake   address@hidden    +1-919-301-3266
> Libvirt virtualization library http://libvirt.org
>