[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/22] hw/9pfs: avoid buffer overrun
From: |
Aneesh Kumar K.V |
Subject: |
Re: [Qemu-devel] [PATCH 04/22] hw/9pfs: avoid buffer overrun |
Date: |
Wed, 09 May 2012 18:38:19 +0530 |
Jim Meyering <address@hidden> writes:
> From: Jim Meyering <address@hidden>
>
> v9fs_add_dir_node and qemu_v9fs_synth_add_file used strncpy
> to form node->name, which requires NUL-termination, but
> strncpy does not ensure NUL-termination.
> Use pstrcpy, which does.
>
> Signed-off-by: Jim Meyering <address@hidden>
Acked-by: Aneesh Kumar K.V <address@hidden>
> ---
> hw/9pfs/virtio-9p-synth.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/9pfs/virtio-9p-synth.c b/hw/9pfs/virtio-9p-synth.c
> index 92e0b09..e95a856 100644
> --- a/hw/9pfs/virtio-9p-synth.c
> +++ b/hw/9pfs/virtio-9p-synth.c
> @@ -58,7 +58,7 @@ static V9fsSynthNode *v9fs_add_dir_node(V9fsSynthNode
> *parent, int mode,
> node->attr->read = NULL;
> }
> node->private = node;
> - strncpy(node->name, name, sizeof(node->name));
> + pstrcpy(node->name, sizeof(node->name), name);
> QLIST_INSERT_HEAD_RCU(&parent->child, node, sibling);
> return node;
> }
> @@ -132,7 +132,7 @@ int qemu_v9fs_synth_add_file(V9fsSynthNode *parent, int
> mode,
> node->attr->write = write;
> node->attr->mode = mode;
> node->private = arg;
> - strncpy(node->name, name, sizeof(node->name));
> + pstrcpy(node->name, sizeof(node->name), name);
> QLIST_INSERT_HEAD_RCU(&parent->child, node, sibling);
> ret = 0;
> err_out:
> --
> 1.7.10.1.487.ga3935e6
- Re: [Qemu-devel] [PATCH 16/22] qemu-ga: prefer pstrcpy: consistently NUL-terminate ifreq.ifr_name, (continued)
- [Qemu-devel] [PATCH 15/22] target-i386: use pstrcpy, not strncpy, Jim Meyering, 2012/05/09
- [Qemu-devel] [PATCH 07/22] ppc: avoid buffer overrun: use pstrcpy, not strncpy, Jim Meyering, 2012/05/09
- [Qemu-devel] [PATCH 02/22] sheepdog: avoid a few buffer overruns, Jim Meyering, 2012/05/09
- [Qemu-devel] [PATCH 14/22] vscsi: avoid unwarranted strncpy, Jim Meyering, 2012/05/09
- [Qemu-devel] [PATCH 20/22] hw/r2d: add comment: this strncpy use is ok, Jim Meyering, 2012/05/09
- [Qemu-devel] [PATCH 04/22] hw/9pfs: avoid buffer overrun, Jim Meyering, 2012/05/09
- Re: [Qemu-devel] [PATCH 04/22] hw/9pfs: avoid buffer overrun,
Aneesh Kumar K.V <=
- [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Jim Meyering, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Peter Maydell, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Jim Meyering, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Peter Maydell, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Jim Meyering, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Peter Maydell, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Jim Meyering, 2012/05/09
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Anthony Liguori, 2012/05/30
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Jim Meyering, 2012/05/30
- Re: [Qemu-devel] [PATCH 08/22] linux-user: remove two unchecked uses of strdup, Anthony Liguori, 2012/05/30