[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success r
From: |
Luiz Capitulino |
Subject: |
[Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response |
Date: |
Tue, 8 May 2012 14:24:46 -0300 |
Today, qemu-ga may not be able to emit a success response when
guest-shutdown completes. This happens because the VM may vanish
before qemu-ga is able to emit a response.
This semantic is a bit confusing, as it's not clear for clients if
they should wait for a response or how they should check for success.
This commit solves that problem by changing guest-shutdown to never
emit a success response and suggests in the documentation what
clients could do to check for success.
Signed-off-by: Luiz Capitulino <address@hidden>
---
qapi-schema-guest.json | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/qapi-schema-guest.json b/qapi-schema-guest.json
index d7a073e..82f901a 100644
--- a/qapi-schema-guest.json
+++ b/qapi-schema-guest.json
@@ -131,11 +131,15 @@
#
# @mode: #optional "halt", "powerdown" (default), or "reboot"
#
-# Returns: Nothing on success
+# This command does NOT return a response on success. Success condition
+# is indicated by the VM exiting with a zero exit status or, when
+# running with --no-shutdown, by issuing the query-status QMP command
+# to confirm the VM status is "shutdown".
#
# Since: 0.15.0
##
-{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' } }
+{ 'command': 'guest-shutdown', 'data': { '*mode': 'str' },
+ 'success-response': 'no' }
##
# @guest-file-open:
--
1.7.9.2.384.g4a92a
- [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 3/6] qemu-ga: guest-shutdown: don't emit a success response,
Luiz Capitulino <=
- [Qemu-devel] [PATCH 6/6] qemu-ga: guest-suspend-hybrid: don't emit a success response, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 1/6] qapi: add support for command options, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 5/6] qemu-ga: guest-suspend-ram: don't emit a success response, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 2/6] qemu-ga: don't warn on no command return, Luiz Capitulino, 2012/05/08
- [Qemu-devel] [PATCH 4/6] qemu-ga: guest-suspend-disk: don't emit a success response, Luiz Capitulino, 2012/05/08
- Re: [Qemu-devel] [PATCH v2 0/6]: qemu-ga: no success response for certain commands, Michael Roth, 2012/05/09