Re: [Qemu-devel] [PATCH 3/4] runstate: introduce suspended state

[Paolo Bonzini]

Il 04/05/2012 17:02, Luiz Capitulino ha scritto:
> diff --git a/qapi-schema.json b/qapi-schema.json
> index 0166ec2..4dbcb26 100644
> --- a/qapi-schema.json
> +++ b/qapi-schema.json
> @@ -116,12 +116,14 @@
>  #
>  # @shutdown: guest is shut down (and -no-shutdown is in use)
>  #
> +# @suspended: guest is suspended (ACPI S3)
> +#
>  # @watchdog: the watchdog action is configured to pause and has been 
> triggered
>  ##
>  { 'enum': 'RunState',
>    'data': [ 'debug', 'inmigrate', 'internal-error', 'io-error', 'paused',
>              'postmigrate', 'prelaunch', 'finish-migrate', 'restore-vm',
> -            'running', 'save-vm', 'shutdown', 'watchdog' ] }
> +            'running', 'save-vm', 'shutdown', 'suspended', 'watchdog' ] }
>  

This breaks QAPI ABI.

Not really a breaker for this series, but it shows how we are not yet
ready to keep a stable ABI (as opposed to API), and thus any
restrictions on adding optional arguments to commands are premature.
(And IMO wrong, there are plenty of ways to have versioned symbols in C
without breaking the ABI---not talking about ELF symbol versioning).

Paolo