[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu |
Date: |
Fri, 4 May 2012 14:04:43 +0100 |
On 4 May 2012 11:54, Juan Quintela <address@hidden> wrote:
> Use one subsection for each feature. This means that we don't need to
> bump the version field each time that a new feature gets introduced.
>
> Introduce cpsr_vmstate field, as I am not sure if I can "use"
> uncached_cpsr for saving state.
>
> Signed-off-by: Juan Quintela <address@hidden>
> ---
> target-arm/cpu.h | 5 +-
> target-arm/machine.c | 344
> ++++++++++++++++++++++----------------------------
> 2 files changed, 156 insertions(+), 193 deletions(-)
>
> diff --git a/target-arm/cpu.h b/target-arm/cpu.h
> index 9434902..37744c6 100644
> --- a/target-arm/cpu.h
> +++ b/target-arm/cpu.h
> @@ -236,6 +236,9 @@ typedef struct CPUARMState {
> } cp[15];
> void *nvic;
> const struct arm_boot_info *boot_info;
> +
> + /* Fields needed as intermediate for vmstate */
> + uint32_t cpsr_vmstate;
> } CPUARMState;
I still think this is the wrong approach. We need to support
"this is how you read/write this field" functions. See also
target-alpha handling of the fpcr.
-- PMM
- [Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays, (continued)
- [Qemu-devel] [PATCH 09/35] vmstate: introduce float64 arrays, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 19/35] mips: make tlb an embedded struct instead of a pointer, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 20/35] mips: bump migration version to 4, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 18/35] mips: make mvp an embedded struct instead of a pointer, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 26/35] vmstate: remove unneeded includes from target-*/machine.c, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 24/35] vmstate: all cpus converted, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 29/35] vmstate: Add copyright info for lm32 processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 21/35] vmstate: port mips cpu, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu, Juan Quintela, 2012/05/04
- Re: [Qemu-devel] [PATCH 23/35] vmstate: port arm cpu,
Peter Maydell <=
- [Qemu-devel] [PATCH 30/35] vmstate: Add copyright info for cris processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 25/35] vmstate: fix vmstate formating for i386, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 34/35] vmstate: Add copyright info for ppc processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 32/35] vmstate: Add copyright info for i386 processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 28/35] vmstate: Add copyright info for alpha processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 31/35] vmstate: Add copyright info for arm processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 33/35] vmstate: Add copyright info for mips processor, Juan Quintela, 2012/05/04
- [Qemu-devel] [PATCH 27/35] vmstate: rename machine.c to vmstate-cpu.c, Juan Quintela, 2012/05/04