[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 3/6] qdev: Fix memory leak in function set_pci_devfn
From: |
Stefan Weil |
Subject: |
[Qemu-devel] [PATCH 3/6] qdev: Fix memory leak in function set_pci_devfn |
Date: |
Thu, 3 May 2012 07:14:50 +0200 |
Valgrind reported this memory leak which occured very often.
Test scenario:
qemu-system-i386 (no arguments), only BIOS started, terminate with
monitor command (quit).
v2:
Use error_free instead of g_free (hint from Andreas Färber, thanks).
Signed-off-by: Stefan Weil <address@hidden>
Acked-by: Andreas Färber <address@hidden>
---
hw/qdev-properties.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/hw/qdev-properties.c b/hw/qdev-properties.c
index 98dd06a..c5545dc 100644
--- a/hw/qdev-properties.c
+++ b/hw/qdev-properties.c
@@ -834,6 +834,7 @@ static void set_pci_devfn(Object *obj, Visitor *v, void
*opaque,
visit_type_str(v, &str, name, &local_err);
if (local_err) {
+ error_free(local_err);
return set_int32(obj, v, opaque, name, errp);
}
--
1.7.9
- [Qemu-devel] [PULL 1.1 0/6] Missing patches for QEMU 1.1, Stefan Weil, 2012/05/03
- [Qemu-devel] [PATCH 1/6] target-mips: Remove unused inline function, Stefan Weil, 2012/05/03
- [Qemu-devel] [PATCH 3/6] qdev: Fix memory leak in function set_pci_devfn,
Stefan Weil <=
- [Qemu-devel] [PATCH 2/6] arm-semi: Rename SYS_XXX macros to TARGET_SYS_XXX (fixes compiler warning), Stefan Weil, 2012/05/03
- [Qemu-devel] [PATCH 5/6] qom: Fix memory leak in function container_get, Stefan Weil, 2012/05/03
- [Qemu-devel] [PATCH 4/6] hw/pc_sysfw: Fix memory leak, Stefan Weil, 2012/05/03
- [Qemu-devel] [PATCH 6/6] qemu-timer: Fix limits for w32 mmtimer, Stefan Weil, 2012/05/03
- Re: [Qemu-devel] [PULL 1.1 0/6] Missing patches for QEMU 1.1, Anthony Liguori, 2012/05/08