Re: [Qemu-devel] [PATCH 04/14] qdev: don't allow globals to be set by bus name

[Anthony Liguori]

On 05/01/2012 03:37 PM, Paolo Bonzini wrote:
> Il 01/05/2012 20:18, Anthony Liguori ha scritto:
> > This is technically a compatibility breaker.  However:
> >
> > 1) libvirt does not rely on this (it always uses the driver name)
> >
> > 2) This behavior isn't actually documented anywhere (the docs just say driver).
> >
> > 3) I suspect there are less than three people on earth that even know this is
> >     possible (minus the people reading this message).
> >
> > So I think we can safely break it :-)
>
> Does this work with compat properties set on a bus?

No :-(

This is pretty easy to fix though.  The attached should do the trick, I'll 
update and send out.

  Even if it does,
> perhaps it's better to avoid the cleverness and wait for my series that
> moves bus properties to the appropriate abstract superclass.

This series does that FWIW (patch 6/14).

Regards,

Anthony Liguori

> Paolo

foo
Description: Text document