[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Replace int16 type with int_f
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Replace int16 type with int_fast16_t |
Date: |
Thu, 26 Apr 2012 17:14:29 +0100 |
On 25 April 2012 23:15, Andreas Färber <address@hidden> wrote:
> From: Andreas Färber <address@hidden>
>
> Based on the following Coccinelle patch:
>
> @@
> typedef int16, int_fast16_t;
> @@
> -int16
> +int_fast16_t
>
> Avoids a workaround for AIX.
>
> Add typedef for pre-10 Solaris.
>
> Signed-off-by: Andreas Färber <address@hidden>
> Cc: malc <address@hidden>
> Cc: Ben Taylor <address@hidden>
Reviewed-by: Peter Maydell <address@hidden>
This is a pretty safe change, because the only external-to-softfloat
APIs this changes are a couple used only by the ARM target (which
I've tested and am happy are OK). The ARM vfp/neon tests I've run
should have exercised the rest of the softfloat code reasonably
well so the internal-to-softfloat changes should be OK too. In
any case the type wasn't exactly-16-bits before so we already
know the code is OK with the type being potentially wider than
16 bits.
-- PMM
- [Qemu-devel] [PATCH v2 0/4] softfloat: Fix build on Darwin (uint16), Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v2 1/4] softfloat: Fix mixups of int and int16, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v2 2/4] target-mips: Move definition of uint_fast{8, 16}_t to osdep.h, Andreas Färber, 2012/04/25
- [Qemu-devel] [PATCH v2 4/4] softfloat: Replace int16 type with int_fast16_t, Andreas Färber, 2012/04/25
- Re: [Qemu-devel] [PATCH v2 4/4] softfloat: Replace int16 type with int_fast16_t,
Peter Maydell <=
- [Qemu-devel] [PATCH v2 3/4] softfloat: Replace uint16 type with uint_fast16_t, Andreas Färber, 2012/04/25
- Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix build on Darwin (uint16), Bernhard Walle, 2012/04/26
- Re: [Qemu-devel] [PATCH v2 0/4] softfloat: Fix build on Darwin (uint16), Blue Swirl, 2012/04/28