[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by
From: |
Bernhard Walle |
Subject: |
Re: [Qemu-devel] [PATCH] configure: Don't build bsd-user on Mac OS X by default |
Date: |
Thu, 26 Apr 2012 15:53:53 +0200 |
User-agent: |
Mozilla/5.0 (Macintosh; Intel Mac OS X 10.7; rv:12.0) Gecko/20120420 Thunderbird/12.0 |
Am 26.04.12 14:50, schrieb Andreas Färber:
> Am 26.04.2012 12:30, schrieb Bernhard Walle:
>>
>> Thanks. I already stumbled over this when trying to test your
>> uint16 fixes (they work for me, BTW).
>
> In that case please add an appropriate tag (e.g., Tested-by) as reply
> there (best with info on what architecture and OS version you tested).
> Otherwise there's no telling whether no one looked at it, and they will
> bitrot again like in January and before that. Patch review and reacting
> to patch reviews are the weak spot of Mac OS X host support, sadly.
>
> If you add an Acked-by to this one, I can send a PULL for this and
> darwin-user removal right away. uint16 touches all hosts and virtually
> all guests so needs more review than the Darwin-only changes.
Thanks for the hint. Hope my replies are ok now.
I thought Acked-by is only for experts...
Regards,
Bernhard