[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH v3 01/15] target-i386: Fix x86_cpuid_set_model_id()
From: |
Andreas Färber |
Subject: |
[Qemu-devel] [PATCH v3 01/15] target-i386: Fix x86_cpuid_set_model_id() |
Date: |
Tue, 24 Apr 2012 16:22:31 +0200 |
Don't assume zeroed cpuid_model[] fields.
This didn't break anything yet but QOM properties should be able to set
the value to something else without setting an intermediate zero string.
Signed-off-by: Andreas Färber <address@hidden>
---
Since I managed to screw this change up on first try (using size 12),
let's better be safe than sorry and properly post the v3 for review. :-)
v2 -> v3:
* Use memset() instead of for loop (suggested by Igor Mammedov).
target-i386/cpu.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index 3df53ca..e1517e6 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -627,6 +627,7 @@ static void x86_cpuid_set_model_id(CPUX86State *env, const
char *model_id)
model_id = "";
}
len = strlen(model_id);
+ memset(env->cpuid_model, 0, 48);
for (i = 0; i < 48; i++) {
if (i >= len) {
c = '\0';
--
1.7.7
- [Qemu-devel] [PATCH v2 00/15] QOM'ify x86 CPU, part 2: properties, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 02/15] target-i386: Pass X86CPU to cpu_x86_register(), Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 06/15] target-i386: Add "stepping" property to X86CPU, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 08/15] target-i386: Add property getter for CPU family, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 03/15] target-i386: Add range check for -cpu , family=x, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 05/15] target-i386: Add "model" property to X86CPU, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 04/15] target-i386: Add "family" property to X86CPU, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 13/15] target-i386: Introduce "xlevel" property for X86CPU, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 11/15] target-i386: Add property getter for CPU model-id, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 10/15] target-i386: Add property getter for CPU stepping, Andreas Färber, 2012/04/24
- [Qemu-devel] [PATCH v2 09/15] target-i386: Add property getter for CPU model, Andreas Färber, 2012/04/24