Re: [Qemu-devel] [PATCH] qtest: fix memread and memwrite on 32 bit hosts

[Blue Swirl]

On Mon, Apr 23, 2012 at 19:13, Anthony Liguori <address@hidden> wrote:
> On 04/23/2012 01:55 PM, Blue Swirl wrote:
>>
>> Use PRIx64 to print 64 bit values to avoid truncation
>> on 32 bit hosts.
>>
>> Signed-off-by: Blue Swirl<address@hidden>
>
>
> Reviewed-by: Anthony Liguori <address@hidden>

Thanks for the review, applied.

>
> Regards,
>
> Anthony Liguori
>
>
>> ---
>>  tests/libqtest.c |    4 ++--
>>  1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/tests/libqtest.c b/tests/libqtest.c
>> index d47969e..1ce6fa1 100644
>> --- a/tests/libqtest.c
>> +++ b/tests/libqtest.c
>> @@ -356,7 +356,7 @@ void qtest_memread(QTestState *s, uint64_t addr,
>> void *data, size_t size)
>>      gchar **args;
>>      size_t i;
>>
>> -    qtest_sendf(s, "read 0x%x 0x%x\n", addr, size);
>> +    qtest_sendf(s, "read 0x%" PRIx64 " 0x%x\n", addr, size);
>>      args = qtest_rsp(s, 2);
>>
>>      for (i = 0; i<  size; i++) {
>> @@ -378,7 +378,7 @@ void qtest_memwrite(QTestState *s, uint64_t addr,
>> const void *data, size_t size)
>>      const uint8_t *ptr = data;
>>      size_t i;
>>
>> -    qtest_sendf(s, "write 0x%x 0x%x 0x", addr, size);
>> +    qtest_sendf(s, "write 0x%" PRIx64 " 0x%x 0x", addr, size);
>>      for (i = 0; i<  size; i++) {
>>          qtest_sendf(s, "%02x", ptr[i]);
>>      }
>
>