[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] target-arm: Change cpu_arm_init() return ty
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 1/2] target-arm: Change cpu_arm_init() return type to ARMCPU |
Date: |
Mon, 23 Apr 2012 19:23:31 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120328 Thunderbird/11.0.1 |
Am 23.04.2012 19:00, schrieb Peter Maydell:
> On 20 April 2012 18:39, Andreas Färber <address@hidden> wrote:
>> Make cpu_arm_init() return a QOM ARMCPU, so that we don't need to
>> obtain an ARMCPU through arm_env_get_cpu() in machine init code.
>> This requires to adjust the inclusion site of cpu-qom.h and in turn,
>> forward-looking, to homogenize its include order.
>>
>> cpu_init() must still return a CPUARMState for backwards and
>> cross-target compatibility, so adjust the cpu_init macro.
>
> So is the plan that all boards should eventually move over
> to calling cpu_arm_init() rather than cpu_init() ?
Iff they need ARMCPU, they need to call an ARM-specific function.
Currently not all do, so there's no need for mass conversions; since
cpu_copy() still needs the cpu_init alias there'd be no benefit either.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg