[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_addres
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU |
Date: |
Fri, 20 Apr 2012 19:01:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 14.04.2012 18:42, schrieb Peter Maydell:
> Move the A9 config_base_address cp15 register reset value to
> ARMCPU. This should become a QOM property so that the Highbank
> board can set it without having to pull in cpu-qom.h, but at
> least this avoids the implicit dependency on reset ordering
> that the previous workaround had.
>
> Cc: Mark Langsdorf <address@hidden>
> Signed-off-by: Peter Maydell <address@hidden>
> ---
> hw/highbank.c | 11 ++++-------
> target-arm/cpu-qom.h | 1 +
> target-arm/cpu.c | 4 +---
> 3 files changed, 6 insertions(+), 10 deletions(-)
>
> diff --git a/hw/highbank.c b/hw/highbank.c
> index 906eed5..9ff639b 100644
> --- a/hw/highbank.c
> +++ b/hw/highbank.c
[...]
> @@ -213,14 +207,17 @@ static void highbank_init(ram_addr_t ram_size,
> }
>
> for (n = 0; n < smp_cpus; n++) {
> + ARMCPU *cpu;
> env = cpu_init(cpu_model);
> if (!env) {
> fprintf(stderr, "Unable to find CPU definition\n");
> exit(1);
> }
> + cpu = arm_env_get_cpu(env);
Ugh, I'd like to avoid this creeping into boards... Would you mind
applying the updated 1-13 (they should all have some tag of mine now)
and rebasing this one on a patch that I'll send you shortly, changing
cpu_arm_init() signature?
Otherwise looks okay.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH v2 00/14] target-arm: Create QOM subclass per CPU implementation, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 09/14] target-arm: Move feature register setup to per-CPU init fns, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU, Peter Maydell, 2012/04/14
- Re: [Qemu-devel] [PATCH v2 14/14] target-arm: Move A9 config_base_address reset value to ARMCPU,
Andreas Färber <=
- [Qemu-devel] [PATCH v2 10/14] target-arm: Move OMAP cp15_i_{max, min} reset to cpu_state_reset, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 07/14] target-arm: Drop JTAG_ID documentation, Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 12/14] target-arm: Drop cpu_reset_model_id(), Peter Maydell, 2012/04/14
- [Qemu-devel] [PATCH v2 06/14] target-arm: Move SCTLR reset value setup to per cpu init fns, Peter Maydell, 2012/04/14