[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 04/15] target-i386: Add "family" property to X86
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH 04/15] target-i386: Add "family" property to X86CPU |
Date: |
Fri, 20 Apr 2012 13:16:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120312 Thunderbird/11.0 |
Am 20.04.2012 00:34, schrieb Michael Roth:
> On Wed, Apr 18, 2012 at 01:11:08AM +0200, Andreas Färber wrote:
>> Add the property early in the initfn so that it can be used in helpers
>> such as mce_init().
>>
>> Signed-off-by: Andreas Färber <address@hidden>
>> ---
>> target-i386/cpu.c | 38 +++++++++++++++++++++++++++++++++-----
>> 1 files changed, 33 insertions(+), 5 deletions(-)
>>
>> diff --git a/target-i386/cpu.c b/target-i386/cpu.c
>> index d30185b..aa0d328 100644
>> --- a/target-i386/cpu.c
>> +++ b/target-i386/cpu.c
[...]
>> @@ -952,6 +972,9 @@ int cpu_x86_register(X86CPU *cpu, const char *cpu_model)
>> env->cpuid_svm_features &= TCG_SVM_FEATURES;
>> }
>> x86_cpuid_set_model_id(env, def->model_id);
>> + if (error_is_set(&error)) {
>
> Missing an error_free(error) here
Thanks, fixed on qom-cpu-x86 branch.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH 00/15] QOM'ify x86 CPU, part 2: properties, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 01/15] target-i386: Fix x86_cpuid_set_model_id(), Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 10/15] target-i386: Add property getter for CPU stepping, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 02/15] target-i386: Pass X86CPU to cpu_x86_register(), Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 12/15] target-i386: Introduce "level" property for X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 04/15] target-i386: Add "family" property to X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 03/15] target-i386: Add range check for -cpu , family=x, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 06/15] target-i386: Add "stepping" property to X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 13/15] target-i386: Introduce "xlevel" property for X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 05/15] target-i386: Add "model" property to X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 14/15] target-i386: Prepare "vendor" property for X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 15/15] target-i386: Introduce "tsc-frequency" property for X86CPU, Andreas Färber, 2012/04/17
- [Qemu-devel] [PATCH 11/15] target-i386: Add property getter for CPU model-id, Andreas Färber, 2012/04/17