Re: [Qemu-devel] [PULL 00/20] Block patches

[Kevin Wolf]

Am 20.04.2012 12:38, schrieb Andreas Färber:
> Am 20.04.2012 12:37, schrieb Kevin Wolf:
>> Am 20.04.2012 12:16, schrieb Andreas Färber:
>>> [...] I've been seeing the following annoying
>>> problem on master:

>>> However `hostname` returns "<myhostname>.site" just fine, and I don't
>>> understand why a user's local hostname should be causing 100% test
>>> failures for block I/O tests in the first place...
>>>
>>> Could someone please check on that?
>>
>> common.config has this line:
>>
>>    HOST=`hostname -s`
>>
>> Does hostname -s work as well when you invoke it manually?
> 
> Ah no, that one doesn't. (I spotted just `hostname` in common.rc.)

Interesting that it can fail when getting the full host name works.

>> But anyway,
>> $HOST seems to be completely unused, so I guess we could just remove
>> this line.
> 
> Maybe it matters for NBD or iSCSI? But if prerequisites were not right I
> would expect the tests to be skipped, not failing.

I suspect the author (Christoph?) just didn't expect that this could
ever fail.

And well, qemu-iotests doesn't do any NBD or iSCSI tests (yet). I
grepped for HOST and found no user at all.

Kevin