Re: [Qemu-devel] Compile/link errors

[Andreas Färber]

Am 24.02.2012 19:24, schrieb Anthony Liguori:
> On 02/24/2012 12:09 PM, Andreas Färber wrote:
>> Am 24.02.2012 18:27, schrieb Anthony Liguori:
>>> On 02/24/2012 11:11 AM, Gerhard Wiesinger wrote:
>>>> Hello,
>>>>
>>>> I'm having compile/link errors on
>>>> 85f38553031b1a6e07f786c9ab0d403af7252b4f:
>>>> LINK x86_64-softmmu/qemu-system-x86_64
>>>> ../libhw64/virtio-pci.o: In function `virtio_scsi_exit_pci':
>>>> /root/download/qemu/git/qemu/hw/virtio-pci.c:956: undefined
>>>> reference to
>>>> `virtio_scsi_exit'
>>>> ../libhw64/virtio-pci.o: In function `virtio_scsi_init_pci':
>>>> /root/download/qemu/git/qemu/hw/virtio-pci.c:939: undefined
>>>> reference to
>>>> `virtio_scsi_init'
>>>> collect2: ld returned 1 exit status
>>>>
>>>> Clean compile.
>>>>
>>>> Any ideas?
>>>
>>> You have a stale configuration file.  A 'make distclean' should help.
>>
>> Such errors indicate a dependency issue that should be fixed though.
>> (Same error here. Rebuilding after rm -rf * worked.)
>>
>> When I change target-specific default configs it always seemed to work
>> okay, is pci.mak different in any way? Or maybe some make target is
>> lacking a dependency on the regenerated config files?
> 
> %/config-devices.mak: default-configs/%.mak
> 
> I think you could add default-configs/pci.mak to this stanza and it
> would have regenerated here.

I've revisited this now, and it seems that scripts/make_device_config.sh
already generates a .d file for each generated config, so in theory your
suggestion should not be necessary.

I wonder if the issue is that that dependency file says
"x86_64-softmmu/default-configs.mak: /path/to/default-configs/pci.mak"
rather than just "default-configs.mak: /path/to/default-configs/pci.mak"?

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg