[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreez
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-devel] [PATCH 1/2] qemu-ga: generate missing stubs for fsfreeze |
|
Date: |
Thu, 19 Apr 2012 11:56:28 -0500 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
On 04/19/2012 11:05 AM, Michael Roth wrote:
> When linux-specific commands (including guest-fsfreeze-*) were consolidated
> under defined(__linux__), we forgot to account for the case where
> defined(__linux__) && !defined(FIFREEZE). As a result stubs are no longer
> being generated on linux hosts that don't have FIFREEZE support. Fix
> this.
>
> Tested-by: Andreas Färber <address@hidden>
> Reviewed-by: Luiz Capitulino <address@hidden>
> Signed-off-by: Michael Roth <address@hidden>
> ---
> qga/commands-posix.c | 36 ++++++++++++++++++++----------------
> 1 files changed, 20 insertions(+), 16 deletions(-)
I know it moves more code around, but I think un-nesting CONFIG_FSFREEZE
from within __linux__ is more logically correct.
r~