Re: [Qemu-devel] [PATCH] tracetool: handle DTrace keywords 'in', 'next', 'self'

[Stefan Hajnoczi]

On Mon, Apr 16, 2012 at 12:53:58PM +0100, Stefan Hajnoczi wrote:
> Language keywords cannot be used as argument names.  The DTrace backend
> appends an underscore to the argument name in order to make the argument
> name legal.
> 
> This patch adds 'in', 'next', and 'self' keywords to dtrace.py.
> 
> Also drop the unnecessary argument name lstrip() call.  The
> Arguments.build() method already ensures there is no space around
> argument names.  Furthermore it is misleading to do the lstrip() *after*
> checking against keywords because the keyword check would not match if
> spaces were in the name.
> 
> Signed-off-by: Stefan Hajnoczi <address@hidden>
> ---
>  scripts/tracetool/backend/dtrace.py |    8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)

Applied to the tracing patches tree:
https://github.com/stefanha/qemu/commits/tracing

Stefan