Re: [Qemu-devel] [PATCH] add function DMA_set_return and delete bh_schedule in dma.c

[Stefan Hajnoczi]

On Mon, Apr 16, 2012 at 6:29 AM, Li Zhi Hui <address@hidden> wrote:
> add function DMA_set_return and delete bh_schedule in dma.c

Please explain the reason for these code changes in the commit description.

>
> Signed-off-by: Li Zhi Hui <address@hidden>
> ---
>  hw/dma.c |   21 ++++++++++++++-------
>  hw/isa.h |    1 +
>  2 files changed, 15 insertions(+), 7 deletions(-)
>
> diff --git a/hw/dma.c b/hw/dma.c
> index 0a9322d..48e153a 100644
> --- a/hw/dma.c
> +++ b/hw/dma.c
> @@ -357,12 +357,10 @@ static void DMA_run (void)
>  {
>     struct dma_cont *d;
>     int icont, ichan;
> -    int rearm = 0;

Why are you removing the rearm behavior?  I'm pretty sure other ISA
devices rely on this otherwise the code wouldn't exist.

Stefan