Re: [Qemu-devel] [PATCH] configure: require glib 2.12, 2.20 for mingw32

[Daniel P. Berrange]

On Mon, Apr 16, 2012 at 01:08:01PM +0200, Gerd Hoffmann wrote:
> On 04/05/12 13:01, Paolo Bonzini wrote:
> > These are pretty sane requirements to move forward with glib usage.
> > 2.12 is the version found in RHEL/CentOS 5, and 2.20 is the
> > first version to support g_poll.  Without g_poll, we cannot
> > integrate well with the glib main loop.
> 
> We have a glib-related rhel5 build failure though:
> 
>   CC    qapi/qmp-input-visitor.o
> qapi/qmp-input-visitor.c: In function ‘qmp_input_pop’:
> qapi/qmp-input-visitor.c:92: error: ‘GHashTableIter’ undeclared (first
> use in this function)
> qapi/qmp-input-visitor.c:92: error: (Each undeclared identifier is
> reported only once
> qapi/qmp-input-visitor.c:92: error: for each function it appears in.)
> qapi/qmp-input-visitor.c:92: error: expected ‘;’ before ‘iter’
> cc1: warnings being treated as errors
> qapi/qmp-input-visitor.c:96: warning: implicit declaration of function
> ‘g_hash_table_iter_init’
> qapi/qmp-input-visitor.c:96: warning: nested extern declaration of
> ‘g_hash_table_iter_init’
> qapi/qmp-input-visitor.c:96: error: ‘iter’ undeclared (first use in this
> function)
> qapi/qmp-input-visitor.c:97: warning: implicit declaration of function
> ‘g_hash_table_iter_next’
> qapi/qmp-input-visitor.c:97: warning: nested extern declaration of
> ‘g_hash_table_iter_next’
> make: *** [qapi/qmp-input-visitor.o] Error 1
> 
> Guess 2.12 just hasn't hash tables yet, so we have to figure whenever we
> want raise the minimum glib version or stop using glib hash tables.

Only the use of iterators is a problem and there was a patch posted for
that:

http://lists.nongnu.org/archive/html/qemu-devel/2012-04/msg01623.html

Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|