Re: [Qemu-devel] [PATCH] target-xtensa: add dc233c core

[Andreas Färber]

Am 14.04.2012 03:40, schrieb Max Filippov:
> This is Diamond 233L Standard Core Rev.C (LE), implemented through
> linux/gdb overlay.
> 
> Signed-off-by: Max Filippov <address@hidden>
> ---
>  Makefile.target                        |    1 +
>  target-xtensa/core-dc233c.c            |   28 ++
>  target-xtensa/core-dc233c/core-isa.h   |  475 
> ++++++++++++++++++++++++++++++++
>  target-xtensa/core-dc233c/gdb-config.c |  145 ++++++++++
>  4 files changed, 649 insertions(+), 0 deletions(-)
>  create mode 100644 target-xtensa/core-dc233c.c
>  create mode 100644 target-xtensa/core-dc233c/core-isa.h
>  create mode 100644 target-xtensa/core-dc233c/gdb-config.c
> 
> diff --git a/Makefile.target b/Makefile.target
> index e88b896..04e5b27 100644
> --- a/Makefile.target
> +++ b/Makefile.target
> @@ -414,6 +414,7 @@ obj-xtensa-y += xtensa_sim.o
>  obj-xtensa-y += xtensa_lx60.o
>  obj-xtensa-y += xtensa-semi.o
>  obj-xtensa-y += core-dc232b.o
> +obj-xtensa-y += core-dc233c.o
>  obj-xtensa-y += core-fsf.o
>  
>  main.o: QEMU_CFLAGS+=$(GPROF_CFLAGS)
> diff --git a/target-xtensa/core-dc233c.c b/target-xtensa/core-dc233c.c
> new file mode 100644
> index 0000000..1e6a031
> --- /dev/null
> +++ b/target-xtensa/core-dc233c.c
> @@ -0,0 +1,28 @@

Missing a header with clear license statement.

> +#include "cpu.h"
> +#include "exec-all.h"
> +#include "gdbstub.h"
> +#include "qemu-common.h"
> +#include "host-utils.h"
> +
> +#include "core-dc233c/core-isa.h"
> +#include "overlay_tool.h"
> +
> +static const XtensaConfig dc233c = {
> +    .name = "dc233c",
> +    .options = XTENSA_OPTIONS,
> +    .gdb_regmap = {
> +        .num_regs = 121,
> +        .num_core_regs = 52,
> +        .reg = {
> +#include "core-dc233c/gdb-config.c"
> +        }
> +    },
> +    .nareg = XCHAL_NUM_AREGS,
> +    .ndepc = 1,
> +    EXCEPTIONS_SECTION,
> +    INTERRUPTS_SECTION,
> +    TLB_SECTION,
> +    .clock_freq_khz = 10000,
> +};
> +
> +REGISTER_CORE(dc233c)

Otherwise looks good up to here. The rest is imported files from what I
understand.

Andreas

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg