[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into accou
From: |
Peter Maydell |
Subject: |
Re: [Qemu-devel] Build broken -- linux-user: take RESERVED_VA into account for g2h_valid() |
Date: |
Thu, 12 Apr 2012 11:18:28 +0100 |
On 12 April 2012 08:41, Peter Maydell <address@hidden> wrote:
> On 12 April 2012 05:50, Stefan Weil <address@hidden> wrote:
>> Please use 'uintptr_t' instead of 'unsigned long'.
>>
>> It does not matter in this special case, but guest_base and
>> reserved_va will be changed by my patches for w64 to use
>> uintptr_t. The data types 'long' and 'unsigned long' are
>> should be avoided.
>
> Yeah, I was just following the linux-user practice, but if you're
> changing those (even though they obviously never get used on w64)
> I can make this one uintptr_t too.
... just realised I can't do this, because it would conflict
with the extern declaration in cpu-all.h. All the *-user need
to change this from unsigned long to uintptr_t at once, so you'll
need to do it in your w64 patches I'm afraid.
-- PMM