[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-leng
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 12/13] qapi: support for keyworded variable-length argument list |
Date: |
Tue, 10 Apr 2012 13:46:54 -0300 |
On Tue, 10 Apr 2012 18:40:25 +0200
Paolo Bonzini <address@hidden> wrote:
> Il 10/04/2012 16:30, Luiz Capitulino ha scritto:
> > On Tue, 10 Apr 2012 16:27:43 +0200
> > Paolo Bonzini <address@hidden> wrote:
> >
> >> Il 10/04/2012 16:23, Luiz Capitulino ha scritto:
> >>>>> Regarding device_add ? and device_add foo,? I would implement it as
> >>>>> separate QMP commands hooking into QOM, such as qom_list_types (taking
> >>>>> the superclass as an optional argument) and qom_properties. But the
> >>>>> latter first needs static properties to move up from devices to objects.
> >>>>> I'll take a look at that.
> >>> Have you?
> >>
> >> Yes, patches were on the list. I'll submit v2 tomorrow or thursday.
> >
> > Great.
> >
> >>> I think that for device_add foo,? we could introduce
> >>> qom-list-type-properties.
> >>> Seems simple if limited to devices, not sure how to make it generic
> >>> though.
> >>
> >> With those patches you can make it generic.
> >
> > Cool, what about device_add ?, any recommendations?
>
> That's easier, you can just list non-abstract types with TYPE_DEVICE
> superclass (note that's a macro).
By using qom-list-types? The problem is how to export fields like 'no_user'
in QMP.