[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 23/25] qom: add realized property
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [PATCH 23/25] qom: add realized property |
Date: |
Thu, 05 Apr 2012 16:16:58 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 05/04/2012 15:31, Andreas Färber ha scritto:
> Here's how I see it:
>
> * You add a realize callback to ObjectClass like I did, you add the
> Error** parameter that was requested as feedback to mine.
> * You add a static object_realize() method that clashes with my
> introducing it as a public wrapper function.
> * You introduce a function object_get_realized() like I did, only you
> defer your implementation to object_is_realized() which I didn't have
> and used a new bool realized instead of a state enum (since I left qdev
> unmodified).
> * You introduce a function object_set_realized() like I did, only you
> change the logic to also do unrealize.
> * You introduce additional stuff that I don't particularly care about.
Since we're nitpicking, I also do correct error propagation.
> So my point is, whether you've read some patch or not, I just can't
> understand why you couldn't wait a week for me to resend the updated
> version
Because a week is a long time 10 days before the feature freeze, and
(via object_is_realized and a few other small bits) the whole series
depends on the implementation of realized.
> While having unrealize and propagation is certainly nice, the most
> serious issue with yours I see is that it doesn't offer me a way to
> actually make use of it outside qdev, so that *I* am left with no
> benefit from your patch!
Can you explain? I definitely would need to fix this.
> Some practical thoughts on how to align both approaches would be helpful
> here. For starters, should I name my function object_realize_nofail()
> instead?
Yes, that would be an idea. I would hope that long-term there would be
only one object_realize call during in initial machine creation (i.e.
except for hot-plug), but it would be fine as a start.
> And could you prefer _one over _1 in your patch please?
Yes.
> If your problem is Signed-off-by specifically, feel free to invent some
> inofficial tag such as Inspired-by or Derived-from-commit-message-by or
> resort to a textual reference.
I can add the SoB, no problem.
Paolo
- [Qemu-devel] [PATCH 14/25] qapi: add Visitor interfaces for uint*_t and int*_t, (continued)
- [Qemu-devel] [PATCH 14/25] qapi: add Visitor interfaces for uint*_t and int*_t, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 15/25] qdev: use int32_t container for devfn property, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 17/25] qdev: remove PropertyInfo range checking, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 19/25] qom: push state up to Object, Paolo Bonzini, 2012/04/03
- [Qemu-devel] [PATCH 23/25] qom: add realized property, Paolo Bonzini, 2012/04/03
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Andreas Färber, 2012/04/03
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Paolo Bonzini, 2012/04/03
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Andreas Färber, 2012/04/05
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Paolo Bonzini, 2012/04/05
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Andreas Färber, 2012/04/05
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property,
Paolo Bonzini <=
- Re: [Qemu-devel] [PATCH 23/25] qom: add realized property, Anthony Liguori, 2012/04/05
[Qemu-devel] [PATCH 24/25] qdev: implement qdev_init on top of realize, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 18/25] qdev: remove qdev_prop_exists, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 20/25] qdev: generalize properties to Objects, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 25/25] qdev: split part of device_finalize to device_unrealize, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 21/25] qdev: move bulk of qdev-properties.c to qom/object.c, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 16/25] qdev: switch property accessors to fixed-width visitor interfaces, Paolo Bonzini, 2012/04/03
[Qemu-devel] [PATCH 22/25] qom: push static properties to Object, Paolo Bonzini, 2012/04/03