Re: [Qemu-devel] [PATCH 02/10] coroutine: rename unlock_bh_queue to co_runnable_queue

[Paolo Bonzini]

Il 03/04/2012 10:38, Lai Jiangshan ha scritto:
> It stands for runnable Coroutines.
> 
> Signed-off-by: Lai Jiangshan <address@hidden>
> ---
>  qemu-coroutine-lock.c |   18 +++++++++---------
>  1 files changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git a/qemu-coroutine-lock.c b/qemu-coroutine-lock.c
> index 26ad76b..10e8dbb 100644
> --- a/qemu-coroutine-lock.c
> +++ b/qemu-coroutine-lock.c
> @@ -29,17 +29,17 @@
>  #include "main-loop.h"
>  #include "trace.h"
>  
> -static QTAILQ_HEAD(, Coroutine) unlock_bh_queue =
> -    QTAILQ_HEAD_INITIALIZER(unlock_bh_queue);
> -static QEMUBH* unlock_bh;
> +static QTAILQ_HEAD(, Coroutine) co_runnable_queue =
> +    QTAILQ_HEAD_INITIALIZER(co_runnable_queue);
> +static QEMUBH* co_runnable_bh;
>  
>  static void qemu_co_queue_next_bh(void *opaque)
>  {
>      Coroutine *next;
>  
>      trace_qemu_co_queue_next_bh();
> -    while ((next = QTAILQ_FIRST(&unlock_bh_queue))) {
> -        QTAILQ_REMOVE(&unlock_bh_queue, next, co_queue_next);
> +    while ((next = QTAILQ_FIRST(&co_runnable_queue))) {
> +        QTAILQ_REMOVE(&co_runnable_queue, next, co_queue_next);
>          qemu_coroutine_enter(next, NULL);
>      }
>  }
> @@ -48,8 +48,8 @@ void qemu_co_queue_init(CoQueue *queue)
>  {
>      QTAILQ_INIT(&queue->entries);
>  
> -    if (!unlock_bh) {
> -        unlock_bh = qemu_bh_new(qemu_co_queue_next_bh, NULL);
> +    if (!co_runnable_bh) {
> +        co_runnable_bh = qemu_bh_new(qemu_co_queue_next_bh, NULL);
>      }
>  }
>  
> @@ -76,9 +76,9 @@ bool qemu_co_queue_next(CoQueue *queue)
>      next = QTAILQ_FIRST(&queue->entries);
>      if (next) {
>          QTAILQ_REMOVE(&queue->entries, next, co_queue_next);
> -        QTAILQ_INSERT_TAIL(&unlock_bh_queue, next, co_queue_next);
> +        QTAILQ_INSERT_TAIL(&co_runnable_queue, next, co_queue_next);
>          trace_qemu_co_queue_next(next);
> -        qemu_bh_schedule(unlock_bh);
> +        qemu_bh_schedule(co_runnable_bh);
>      }
>  
>      return (next != NULL);

Reviewed-by: Paolo Bonzini <address@hidden>