[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] qdev property listing broken
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] qdev property listing broken |
Date: |
Tue, 03 Apr 2012 00:03:09 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120329 Thunderbird/11.0.1 |
Il 02/04/2012 22:07, Peter Maydell ha scritto:
> On 2 April 2012 20:40, Paolo Bonzini <address@hidden> wrote:
>> diff --git a/hw/qdev-monitor.c b/hw/qdev-monitor.c
>> index a310cc7..923519c 100644
>> --- a/hw/qdev-monitor.c
>> +++ b/hw/qdev-monitor.c
>> @@ -157,7 +157,7 @@ int qdev_device_help(QemuOpts *opts)
>> * for removal. This conditional should be removed along with
>> * it.
>> */
>> - if (!prop->info->parse) {
>> + if (!prop->info->get) {
>> continue; /* no way to set it, don't show */
>> }
>
> This looks really weird: there's no "get" method so we conclude
> "no way to *set* it" ?? Is the comment wrong?
See the comment above.
Paolo
Re: [Qemu-devel] qdev property listing broken, Anthony Liguori, 2012/04/02
Re: [Qemu-devel] qdev property listing broken, Jan Kiszka, 2012/04/02