[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support
From: |
Richard Henderson |
Subject: |
Re: [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support |
Date: |
Fri, 30 Mar 2012 08:56:10 -0400 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:11.0) Gecko/20120316 Thunderbird/11.0 |
On 03/30/2012 07:42 AM, Richard Henderson wrote:
> All of your helpers, whereever they receive or return a register value, need
> to use
> type target_ulong and the DEF_HELPER lines need to use "tl". All of the
> mips32
> helpers you've written so far that return values need to make sure to
> sign-extend
> their results from 32-bits.
Hmm, actually I wonder if that's the best advice.
It looks like your translated code isn't going to work well with r0.
I suspect it would be better to add a gen_load_gpr32 function for the
translator that (1) sets 0 for r0, (2a) copies the register for mips32,
and (2b) truncates the register for mips64. That way 32-bit hosts do
not need to use 64-bit arithmetic when unnecessary. You'd need a
gen_store_gpr32 function as well, which for mips64 sign-extends the value.
r~
- [Qemu-devel] [PATCH V4 06/11] Add MIPS DSP GPR-Based Shift instructions Support, (continued)
- [Qemu-devel] [PATCH V4 06/11] Add MIPS DSP GPR-Based Shift instructions Support, Jia Liu, 2012/03/29
- [Qemu-devel] [PATCH V4 07/11] Add MIPS DSP Multiply instructions Support, Jia Liu, 2012/03/29
- [Qemu-devel] [PATCH V4 08/11] Add MIPS DSP Bit/Manipulation instructions Support, Jia Liu, 2012/03/29
- [Qemu-devel] [PATCH V4 09/11] Add MIPS DSP Compare-Pick instructions Support, Jia Liu, 2012/03/29
- [Qemu-devel] [PATCH V4 10/11] Add MIPS DSP Accumulator and DSPControl Access instructions Support, Jia Liu, 2012/03/29
- [Qemu-devel] [PATCH V4 11/11] Add MIPS DSP Testcases, Jia Liu, 2012/03/30
- Re: [Qemu-devel] [PATCH V4 00/11] Qemu MIPS ASE DSP Support, Richard Henderson, 2012/03/30