Re: [Qemu-devel] [PATCH v2] spice_info: add mouse_mode

[Alon Levy]

On Thu, Mar 29, 2012 at 03:19:16PM -0500, Anthony Liguori wrote:
> On 03/26/2012 09:15 AM, Alon Levy wrote:
> >Add mouse_mode, either server or mouse, to qmp and hmp commands, based
> >on spice_server_is_server_mouse added in spice-server 0.10.3.
> >
> >Signed-off-by: Alon Levy<address@hidden>
> >---
> >v1->v2:
> >  report mouse mode "unknown" for qmp too (Gerd Hoffman request)
> >
> >  hmp.c            |    1 +
> >  qapi-schema.json |    7 ++++++-
> >  ui/spice-core.c  |    7 +++++++
> >  3 files changed, 14 insertions(+), 1 deletion(-)
> >
> >diff --git a/hmp.c b/hmp.c
> >index 9cf2d13..8837dd0 100644
> >--- a/hmp.c
> >+++ b/hmp.c
> >@@ -350,6 +350,7 @@ void hmp_info_spice(Monitor *mon)
> >      }
> >      monitor_printf(mon, "        auth: %s\n", info->auth);
> >      monitor_printf(mon, "    compiled: %s\n", info->compiled_version);
> >+    monitor_printf(mon, "  mouse-mode: %s\n", info->mouse_mode);
> >
> >      if (!info->has_channels || info->channels == NULL) {
> >          monitor_printf(mon, "Channels: none\n");
> >diff --git a/qapi-schema.json b/qapi-schema.json
> >index 0d11d6e..72c0080 100644
> >--- a/qapi-schema.json
> >+++ b/qapi-schema.json
> >@@ -654,6 +654,11 @@
> >  #        'spice' uses SASL or direct TLS authentication, depending on 
> > command
> >  #                line options
> >  #
> >+# @mouse-mode: #optional current server mouse mode if spice server is new
> >+#        enough and exposes this information.
> >+#        'client' if client side
> >+#        'server' if server side
> >+#
> 
> Please document which version this is being added in and use an enum
> instead of a string to describe the mode.
> 
> If it's trouble a boolean, then use a bool instead of an enum.

OK. Can't imagine any trouble in using an enum.

> 
> Regards,
> 
> Anthony Liguori