[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Xen-devel] [PATCH V10 1/8] pci_ids: Add INTEL_82599_SF
From: |
Konrad Rzeszutek Wilk |
Subject: |
Re: [Qemu-devel] [Xen-devel] [PATCH V10 1/8] pci_ids: Add INTEL_82599_SFP_VF id. |
Date: |
Wed, 28 Mar 2012 14:53:25 -0400 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 28, 2012 at 12:41:40PM +0100, Anthony PERARD wrote:
You really should say why this is added.. It is so odd just to have
'add this' without any justification. Can you at least say:
"We are using this in our quirk lookup provided by patch
titled: XXXYYY" ?
> Signed-off-by: Anthony PERARD <address@hidden>
> Acked-by: Stefano Stabellini <address@hidden>
> ---
> hw/pci_ids.h | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/hw/pci_ids.h b/hw/pci_ids.h
> index e8235a7..649e6b3 100644
> --- a/hw/pci_ids.h
> +++ b/hw/pci_ids.h
> @@ -118,6 +118,7 @@
> #define PCI_DEVICE_ID_INTEL_82801I_UHCI6 0x2939
> #define PCI_DEVICE_ID_INTEL_82801I_EHCI1 0x293a
> #define PCI_DEVICE_ID_INTEL_82801I_EHCI2 0x293c
> +#define PCI_DEVICE_ID_INTEL_82599_SFP_VF 0x10ed
>
> #define PCI_VENDOR_ID_XEN 0x5853
> #define PCI_DEVICE_ID_XEN_PLATFORM 0x0001
> --
> Anthony PERARD
>
>
> _______________________________________________
> Xen-devel mailing list
> address@hidden
> http://lists.xen.org/xen-devel