[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Suppor
|
From: |
Jia Liu |
|
Subject: |
Re: [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support |
|
Date: |
Wed, 28 Mar 2012 09:27:33 +0800 |
On Tue, Mar 27, 2012 at 11:46 PM, Richard Henderson <address@hidden> wrote:
> On 03/27/12 02:24, Jia Liu wrote:
>> Add MIPS DSP Branch instruction Support.
>>
>> Signed-off-by: Jia Liu <address@hidden>
>
> Reviewed-by: Richard Henderson <address@hidden>
>
>> + case OPC_BPOSGE32:
>> + tcg_gen_setcondi_tl(TCG_COND_GT, bcond, t0, 31);
>
> Nit: It might be better to use TCG_COND_GE ... 32, since that's
> both the name of the insn and its official documentation. Of
> course that makes no difference to the correctness.
>
Yeah, TCG_COND_GE looks better, I'll make it.
>
> r~
Regards,
Jia.
- [Qemu-devel] [PATCH V3 00/12] Qemu MIPS ASE DSP Sup port, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 02/12] Use correct acc value to index cpu_HI/cpu_LO rather than using a fix number, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 03/12] Add MIPS DSP Branch instruction Support, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 04/12] Add MIPS DSP Load instructions Support, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 05/12] Add helper functions for MIPS DSP Arithmetic instructions, Jia Liu, 2012/03/27
- [Qemu-devel] [PATCH V3 06/12] Add helper functions for MIPS DSP GPR-Based Shift instructions, Jia Liu, 2012/03/27