Re: [Qemu-devel] [PATCH 1/2] qemu-iotests: Fix call syntax for qemu-img

[Stefan Weil]

Am 14.03.2012 21:48, schrieb Stefan Weil:
> Am 14.03.2012 20:08, schrieb Eric Blake:
> > On 03/14/2012 12:57 PM, Stefan Weil wrote:
> > > qemu-img requires first options, then file name, then size.
> > >
> > > GNU getopt also allows options at the end, but POSIX getopt
> > > doesn't. Try "export POSIXLY_CORRECT=y" to get the POSIX
> > > behaviour with GNU getopt, too.
> >
> > That's a heavy sledgehammer, that has the potential to affect a lot of
> > other programs called alongside qemu-img. Simpler would be to just pass
> > -- in the command line at the point where you want to force qemu to
> > treat all further arguments without getopt reordering them, as in:
>
> I did not want to suggest that POSIXLY_CORRECT should always
> be set. It's just a way how maintainers can test that there is
> a problem with the current code, and that this problem is
> fixed by my patch.
>
> Passing -- in the command line will not only stop argument
> reordering, it also stops argument parsing which is not
> what we need here.
>
> Regards,
>
> Stefan W.

Ping? These two patches for qemu-iotests are still missing
in QEMU git master. Are there any open questions, or can
they be committed? Should they go through qemu-trivial?

Cheers,
Stefan W.