[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values co
From: |
Meador Inge |
Subject: |
Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly |
Date: |
Tue, 27 Mar 2012 10:07:25 -0500 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Ping.
On 02/24/2012 04:53 PM, Andreas Färber wrote:
> Am 24.02.2012 23:18, schrieb Meador Inge:
>> Fixing a simple typo, s/errno/err/, that caused
>> the error status from GDB semihosted system calls
>> to be returned incorrectly.
>>
>> Signed-off-by: Meador Inge <address@hidden>
>
> Nice catch!
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> Andreas
>
>> ---
>> m68k-semi.c | 2 +-
>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/m68k-semi.c b/m68k-semi.c
>> index bab01ee..6d60ced 100644
>> --- a/m68k-semi.c
>> +++ b/m68k-semi.c
>> @@ -150,7 +150,7 @@ static void m68k_semi_cb(CPUState *env, target_ulong
>> ret, target_ulong err)
>> }
>> /* FIXME - handle put_user() failure */
>> put_user_u32(ret, args);
>> - put_user_u32(errno, args + 4);
>> + put_user_u32(err, args + 4);
>> }
>>
>> #define ARG(n) \
>
--
Meador Inge
CodeSourcery / Mentor Embedded
http://www.mentor.com/embedded-software
- Re: [Qemu-devel] [PATCH v1 1/1] m68k: Return semihosting errno values correctly,
Meador Inge <=