[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linu
From: |
Andreas Färber |
Subject: |
Re: [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only |
Date: |
Mon, 26 Mar 2012 18:35:49 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2 |
Am 20.03.2012 17:10, schrieb Michael Roth:
> On Tue, Mar 20, 2012 at 04:09:53PM +0100, Michal Privoznik wrote:
>> Currently, the implementation of that command is full of
>> Linux specific code. Before any brave man will step into
>> and port it to other OSes, make this function Linux only.
>>
>> Signed-off-by: Michal Privoznik <address@hidden>
>
> Which aspect is linux-specific? getifaddrs() and getnameinfo() seem to
> be available on BSD and OpenSolaris, and we're already stubbed for w32.
> Are you seeing breakage?
The two OpenBSD buildbots were reporting breakages:
http://buildbot.b1-systems.de/qemu/buildslaves/brad_openbsd_current
http://buildbot.b1-systems.de/qemu/buildslaves/kraxel_openbsd49
Unfortunately they rarely nag the people to blame ;) and the reports on
qemu-devel are admittedly a bit brief.
Maybe it might make sense to let the buildbots build your qemu-ga
staging branch as well, Michael? That could catch this in advance.
Andreas
--
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg
- [Qemu-devel] [PATCH] qemu-ga: Make guest-network-get-interfaces Linux only, Michal Privoznik, 2012/03/20
- [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Michael Roth, 2012/03/20
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Luiz Capitulino, 2012/03/23
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Michael Roth, 2012/03/23
- Re: [Qemu-devel] [PATCH] qemu-ga: stub out guest-suspend* for non-linux, Luiz Capitulino, 2012/03/23
- [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Michael Roth, 2012/03/25
- Re: [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Luiz Capitulino, 2012/03/26
- Re: [Qemu-devel] [PATCH] qemu-ga: fix bsd build, and re-org linux-specific implementations, Brad Smith, 2012/03/26