[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] More whitespace and coding s
From: |
Stefan Hajnoczi |
Subject: |
Re: [Qemu-devel] [Qemu-trivial] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes |
Date: |
Thu, 22 Mar 2012 10:27:42 +0000 |
On Thu, Mar 22, 2012 at 12:05 AM, Paolo Bonzini <address@hidden> wrote:
> Il 21/03/2012 22:02, Peter Portante ha scritto:
>> Hi Folks,
>>
>> Please forgive me if you find these changes are annoying, as I am trying to
>> learn the ropes of patch submission with git ahead of making a real patch.
>>
>> While working on the code, I found that scripts/checkpatch.pl will flag lines
>> that I am changing as not adhereing to the codeing standard due to
>> pre-existing coding violations. So I figured I could learn a bit about how to
>> submit patches by fixing these files I will be touching before submitting the
>> code changes.
>
> I think slirp is a mess and it's not worth doing this kind of sweeping
> change. Just ignore checkpatch output for slirp.
Please resend without slirp changes. I suggest including the
individual block/raw-posix.c patch you sent in the new series too.
> For the others, the changes are pretty small so they could be doable.
> If you want to change them then please also add braces around if statements.
If you're doing a whitespace patch please include the 3-space
indentation issues that checkpatch.pl reports in block/raw-posix.c.
> In any case, your patch submission workflow seems to be fine. :P
Please use a prefix in your commit messages, for example "raw-posix:
whitespace cleanup". This gives each commit a unique, useful message
which communicates more than "Yet another whitespace cleanup"-style
messages.
Stefan
- [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Peter Portante, 2012/03/21
- [Qemu-devel] [PATCH 4/4] Yet another missed use of tabs., Peter Portante, 2012/03/21
- [Qemu-devel] [PATCH 3/4] And some final work to complete the coding style upgrade, missed by the previous commit., Peter Portante, 2012/03/21
- [Qemu-devel] [PATCH 2/4] More work to fix up the formatting and the whitespace of this module to conform to the coding standard., Peter Portante, 2012/03/21
- [Qemu-devel] [PATCH 1/4] More whitespace cleanup in preparation for future commits., Peter Portante, 2012/03/21
- Re: [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Paolo Bonzini, 2012/03/21
- Re: [Qemu-devel] [PATCH 0/4] More whitespace and coding style clean ups ahead of future changes, Peter Maydell, 2012/03/22