[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 2/8] vnc: Fix packed boolean struct members
From: |
Stefan Hajnoczi |
Subject: |
[Qemu-devel] [PATCH 2/8] vnc: Fix packed boolean struct members |
Date: |
Mon, 19 Mar 2012 12:22:54 +0000 |
From: Stefan Weil <address@hidden>
This patch fixes warnings reported by splint:
For variables which are packed in a single bit, a signed data type
like 'int' does not make much sense.
There is no obvious reason why the two values should be packed,
so I removed the packing and changed the data type to bool
because both are used as boolean values.
v2:
Some versions of gcc complain after this modification,
for example gcc (Debian 4.4.5-8) 4.4.5):
ui/vnc-auth-sasl.c: In function ‘vnc_sasl_client_cleanup’:
ui/vnc-auth-sasl.c:34: error: suggest parentheses around assignment used as
truth value
Obviously, the compiler does not like code which does
bool = unsigned = bool = 0
Splitting that code in three statements works.
Cc: Anthony Liguori <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
Signed-off-by: Stefan Hajnoczi <address@hidden>
---
ui/vnc-auth-sasl.c | 4 +++-
ui/vnc-auth-sasl.h | 4 ++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/ui/vnc-auth-sasl.c b/ui/vnc-auth-sasl.c
index e2045fc..8fba770 100644
--- a/ui/vnc-auth-sasl.c
+++ b/ui/vnc-auth-sasl.c
@@ -31,7 +31,9 @@
void vnc_sasl_client_cleanup(VncState *vs)
{
if (vs->sasl.conn) {
- vs->sasl.runSSF = vs->sasl.waitWriteSSF = vs->sasl.wantSSF = 0;
+ vs->sasl.runSSF = false;
+ vs->sasl.wantSSF = false;
+ vs->sasl.waitWriteSSF = 0;
vs->sasl.encodedLength = vs->sasl.encodedOffset = 0;
vs->sasl.encoded = NULL;
g_free(vs->sasl.username);
diff --git a/ui/vnc-auth-sasl.h b/ui/vnc-auth-sasl.h
index fd9b18a..ee243a9 100644
--- a/ui/vnc-auth-sasl.h
+++ b/ui/vnc-auth-sasl.h
@@ -37,9 +37,9 @@ typedef struct VncDisplaySASL VncDisplaySASL;
struct VncStateSASL {
sasl_conn_t *conn;
/* If we want to negotiate an SSF layer with client */
- int wantSSF :1;
+ bool wantSSF;
/* If we are now running the SSF layer */
- int runSSF :1;
+ bool runSSF;
/*
* If this is non-zero, then wait for that many bytes
* to be written plain, before switching to SSF encoding
--
1.7.9.1
- [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 19 March 2012, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 3/8] ds1338: Add missing break statement, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 8/8] qemu-ga: for w32, fix leaked handle ov.hEvent in ga_channel_write(), Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 7/8] ioapic: fix build with DEBUG_IOAPIC, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 2/8] vnc: Fix packed boolean struct members,
Stefan Hajnoczi <=
- [Qemu-devel] [PATCH 5/8] cleanup obsolete typedef, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 6/8] .gitignore: add qemu-bridge-helper and option rom build products, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 4/8] monitor: Remove unused bool field 'qapi' in mon_cmd_t struct, Stefan Hajnoczi, 2012/03/19
- [Qemu-devel] [PATCH 1/8] Remove type field in ModuleEntry as it's not used, Stefan Hajnoczi, 2012/03/19
- Re: [Qemu-devel] [PULL 0/8] Trivial patches for 8 to 19 March 2012, Anthony Liguori, 2012/03/19