Re: [Qemu-devel] [Qemu-ppc] [PATCH 1/6] i82378/i82374: do not create DMA controller twice

[Alexander Graf]

On 19.03.2012, at 13:19, Andreas Färber wrote:

> Am 19.03.2012 12:23, schrieb Alexander Graf:
>> 
>> On 19.03.2012, at 12:03, Andreas Färber wrote:
>> 
>>> Am 17.03.2012 15:39, schrieb Hervé Poussineau:
>>>> This fixes a crash in PReP emulation when using DMA controller to access 
>>>> floppy drive.
>>>> 
>>>> Signed-off-by: Hervé Poussineau <address@hidden>
>>> 
>>> Reviewed-by: Andreas Färber <address@hidden>
>> 
>> Why only reviewed?
> 
> Because I didn't test and apply it yet :) before reading through the
> whole series and rebasing prep-up branch. I like feedback to my patches,
> so I provide some myself (and get journaling in my outbox as a bonus).
> 
>> You're the PREP maintainer and this bug shows with PREP, so I don't see why 
>> this shouldn't go through your tree :).
> 
> Correct apart from the spelling, and no one said it should go through
> you or the ppc tree. Relax and have a nice vacation! I never noticed you
> flaming Anthony for reviewing patches he is going to apply later on... ;)

Oh, sorry, it sounded like "Reviewed, someone else please apply it". I didn't 
think of the case where you'd pick it up yourself later :).


Alex