[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions
From: |
Michael Tokarev |
Subject: |
Re: [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions |
Date: |
Sat, 17 Mar 2012 02:36:58 +0400 |
User-agent: |
Mozilla/5.0 (X11; Linux i686 on x86_64; rv:8.0) Gecko/20120216 Icedove/8.0 |
On 17.03.2012 02:29, Paolo Bonzini wrote:
> Il 16/03/2012 23:17, Michael Tokarev ha scritto:
>>>>>> test-iov.c | 158
>>>>>> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>>>
>>>> Makefile changes missing.
>> *sigh* Which changes?
>>
>> I'm sorry but i ran past any sane time limits for this long ago.
>>
>> Come on, which ANOTHER changes do you guys need for all this TRIVIAL stuff
>> ???
>> Can you describe in a few words please?
>
> Changes to tests/Makefile that build test-iov.c and run it with "make
> check".
Thank you for the information. That's about 4 lines of
makefile code. Should I generate a v6 of the patchset for
these 4 lines?
Should this test be runnable on windows, do I need to introduce
a mult-platform unix socket emulation support to run this test?
Besides, should the test be run always, verifying the result of
memcpy() using memcmp(), just in case if some byte flipped in
transit?
Anything else needs a rewrite?
/mjt
- [Qemu-devel] [PATCHv5 00/11] cleanup/consolidate iovec functions, Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying, Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 09/11] export iov_send_recv() and use it in iov_send() and iov_recv(), Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 02/11] change iov_* function prototypes to be more appropriate, Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends, Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 04/11] consolidate qemu_iovec_memset{, _skip}() into single function and use existing iov_memset(), Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 03/11] rewrite iov_* functions, Michael Tokarev, 2012/03/16
[Qemu-devel] [PATCHv5 07/11] change qemu_iovec_to_buf() to match other to, from_buf functions, Michael Tokarev, 2012/03/16
[Qemu-devel] [PATCHv5 06/11] consolidate qemu_iovec_copy() and qemu_iovec_concat() and make them consistent, Michael Tokarev, 2012/03/16
[Qemu-devel] [PATCHv5 01/11] virtio-serial-bus: use correct lengths in control_out() message, Michael Tokarev, 2012/03/16
[Qemu-devel] [PATCHv5 08/11] rename qemu_sendv to iov_send, change proto and move declarations to iov.h, Michael Tokarev, 2012/03/16
[Qemu-devel] [PATCHv5 11/11] rewrite iov_send_recv() and move it to iov.c, Michael Tokarev, 2012/03/16
- [Qemu-devel] [PATCHv5 00/11] cleanup/consolidate iovec functions, Michael Tokarev, 2012/03/19
- [Qemu-devel] [PATCHv5 10/11] cleanup qemu_co_sendv(), qemu_co_recvv() and friends, Michael Tokarev, 2012/03/19
- [Qemu-devel] [PATCHv5 05/11] allow qemu_iovec_from_buffer() to specify offset from which to start copying, Michael Tokarev, 2012/03/19
- [Qemu-devel] [PATCHv5 02/11] change iov_* function prototypes to be more appropriate, Michael Tokarev, 2012/03/19
- [Qemu-devel] [PATCHv5 08/11] rename qemu_sendv to iov_send, change proto and move declarations to iov.h, Michael Tokarev, 2012/03/19