Re: [Qemu-devel] [PATCH 1/5] configure to set shell type

[Peter Maydell]

On 16 March 2012 12:02, Lee Essen <address@hidden> wrote:
> Adds support to configure for controlling which shell to use, defaults to 
> "sh" as before
> but adds "bash" for Solaris/Illumos builds. Plus ensures that tracetool is 
> called with a
> shell.

Ugh. If we have bashisms in our shell scripts/configure/makefiles etc we should
fix them, not paper over them.

If Solaris' /bin/sh isn't a POSIX sh that's a bug in Solaris :-)

> -echo "                           Available backends:" 
> $("$source_path"/scripts/tracetool --list-backends)
> +echo "                           Available backends:" $($shell 
> "$source_path"/scripts/tracetool --list-backends)

This shouldn't be necessary -- tracetool has a #!/bin/sh at the top.
If it needs bash then that should be fixed.

> -sh "$source_path/scripts/tracetool" "--$trace_backend" --check-backend > 
> /dev/null 2> /dev/null
> +$shell "$source_path/scripts/tracetool" "--$trace_backend" --check-backend > 
> /dev/null 2> /dev/null

...and we shouldn't need to use either 'sh' or '$shell' here...

-- PMM