[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu
From: |
Wen Congyang |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to core file |
Date: |
Fri, 16 Mar 2012 14:50:06 +0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.9) Gecko/20100413 Fedora/3.0.4-2.fc13 Thunderbird/3.0.4 |
At 03/16/2012 09:48 AM, HATAYAMA Daisuke Wrote:
> From: Wen Congyang <address@hidden>
> Subject: [RFC][PATCH 08/14 v9] target-i386: Add API to write cpu status to
> core file
> Date: Wed, 14 Mar 2012 10:09:26 +0800
>
>> + memset(note, 0, note_size);
>> + if (type == 0) {
>> + note32 = note;
>> + note32->n_namesz = cpu_to_le32(name_size);
>> + note32->n_descsz = cpu_to_le32(descsz);
>> + note32->n_type = 0;
>> + } else {
>> + note64 = note;
>> + note64->n_namesz = cpu_to_le32(name_size);
>> + note64->n_descsz = cpu_to_le32(descsz);
>> + note64->n_type = 0;
>> + }
>
> Why not give new type for this note information an explicit name?
> Like NT_QEMUCPUSTATE? There might be another type in the future. This
> way there's also a merit that we can know all the existing notes
> relevant to qemu dump by looking at the names in a header file.
Hmm, how to add a new type? Does someont manage this?
Thanks
Wen Congyang
>
> Thanks.
> HATAYAMA, Daisuke
>
>
- [Qemu-devel] [RFC][PATCH 05/14 v9] Add API to get memory mapping, (continued)
- [Qemu-devel] [RFC][PATCH 09/14 v9] target-i386: add API to get dump info, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/13
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Luiz Capitulino, 2012/03/14
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/14
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Luiz Capitulino, 2012/03/15
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/16
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/18
- Re: [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/19