[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutin
From: |
Stefan Weil |
Subject: |
Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines |
Date: |
Thu, 15 Mar 2012 22:28:07 +0100 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.1.16) Gecko/20120207 Iceowl/1.0b1 Icedove/3.0.11 |
Am 05.03.2012 18:40, schrieb Paolo Bonzini:
Conversion to coroutines simplifies the code and removes the need to
duplicate common features of the block layer. Each step in the conversion
is detailed in the corresponding commit message.
Tested with qemu-iotests.
Paolo Bonzini (7):
vdi: basic conversion to coroutines
vdi: move end-of-I/O handling at the end
vdi: merge aio_read_cb and aio_write_cb into callers
vdi: move aiocb fields to locals
vdi: leave bounce buffering to block layer
vdi: do not create useless iovecs
vdi: change goto to loop
block/vdi.c | 421 +++++++++++++-------------------------------------
2 files changed, 108 insertions(+), 317 deletions(-)
Acked-by: Stefan Weil <address@hidden>
Kevin, could you please add Paolo's patches to your block queue?
I did not review each single patch in detail, but the resulting
code looks sane and much better (and shorter) than the current code
(a little like my original code before I had to add asynchronous
I/O support).
As Paolo already tested with qemu-iotests, I did not re-run those
tests.
Thanks,
Stefan W.
- [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 5/7] vdi: leave bounce buffering to block layer, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 1/7] vdi: basic conversion to coroutines, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 7/7] vdi: change goto to loop, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 6/7] vdi: do not create useless iovecs, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 3/7] vdi: merge aio_read_cb and aio_write_cb into callers, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 4/7] vdi: move aiocb fields to locals, Paolo Bonzini, 2012/03/05
- [Qemu-devel] [PATCH 2/7] vdi: move end-of-I/O handling at the end, Paolo Bonzini, 2012/03/05
- Re: [Qemu-devel] [PATCH 0/7] block: convert VDI image format to coroutines,
Stefan Weil <=