[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-devel] [PATCH 0/2] Style and bug on linux-user/signal.c
From: |
Alex Barcelo |
Subject: |
[Qemu-devel] [PATCH 0/2] Style and bug on linux-user/signal.c |
Date: |
Thu, 15 Mar 2012 09:52:06 +0100 |
I tried to send a trivial patch and a v2, but I did it horribly wrong
and seems that have not yet been updated. I thought that maybe
it was a good moment to do things "betterly".
The bug is really a typo, because everywhere there is the same
0 comparison. But each comparison is different one from another, so
the style is quite messed up and the typo becomes non-trivial to
understand.
The first patch is a style patch which makes everything check the
conditions the same way. The second patch corrects a "== 0" that
was missing on an if condition, to be like every other condition.
I sent two "[TRIVIAL]" to the lists that are irrelevant with this
patch. They are:
"sas_ss_flags bug for powerpc"
(v2) "Bad zero comparison for sas_ss_flags on powerpc"
Alex Barcelo (2):
linux-user: Homogeneity on sas_ss_flags checks (signal)
linux-user: Bug on a zero comparation with sas_ss_flags
linux-user/signal.c | 46 ++++++++++++++++++++++++++--------------------
1 files changed, 26 insertions(+), 20 deletions(-)
--
1.7.5.4
- [Qemu-devel] [PATCH 0/2] Style and bug on linux-user/signal.c,
Alex Barcelo <=