[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registe
From: |
Michael Roth |
Subject: |
Re: [Qemu-devel] [PATCH v2 1/3] Add support for 64bit ARM system registers |
Date: |
Wed, 14 Mar 2012 14:38:43 -0500 |
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Wed, Mar 14, 2012 at 10:09:09PM +0300, Alexey Starikovskiy wrote:
> Do I need to do anything beside following or not?
Not sure, ARM folks?
My suggestion would be to lose the the catch-all -EINVAL error we
throw in machine.c:cpu_load() when version_id != CPU_SAVE_VERSION
and only conditionally load 64-bit registers if the source's
version_id >= CPU_SAVE_VERSION. But we've never done that in the
past, and we broke old->new as recently as 2 months ago so I'm not
sure it's worth it since there hasn't been a release since then.
>
> Thanks,
> Alex.
>
> On Wed, Mar 14, 2012 at 11:06 PM, Michael Roth
> <address@hidden> wrote:
> >> > -#define CPU_SAVE_VERSION 6
> >> > +#define CPU_SAVE_VERSION 7
>
- [Qemu-devel] [PATCH v2 2/3] Support for MRCC and MCRR instructions, (continued)