[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memo
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism |
Date: |
Wed, 14 Mar 2012 14:26:48 -0300 |
On Wed, 14 Mar 2012 10:03:15 +0800
Wen Congyang <address@hidden> wrote:
> Changes from v8 to v9:
> 1. remove async support(it will be reimplemented after QAPI async commands
> support
> is finished)
I gave my review on this one (concentrating on the QMP part only), and one
important aspect of this command is that it's a long synchronous operation.
As it runs with vCPUs stopped, the only drawback is that libvirt won't be able
to run other commands in parallel and won't be able to cancel it either. Also
note that this command is most likely to be executed when the guest crashes.
Given all this, it's fine with me to have this as a synchronous command, but
I'd like to get an ACK from libvirt and another one from Jan and/or Anthony.
- [Qemu-devel] [RFC][PATCH 09/14 v9] target-i386: add API to get dump info, (continued)
- [Qemu-devel] [RFC][PATCH 09/14 v9] target-i386: add API to get dump info, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 10/14 v9] make gdb_id() generally avialable, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 11/14 v9] introduce a new monitor command 'dump' to dump guest's memory, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 12/14 v9] support to cancel the current dumping, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 13/14 v9] support to query dumping status, Wen Congyang, 2012/03/13
- [Qemu-devel] [RFC][PATCH 14/14 v9] allow user to dump a fraction of the memory, Wen Congyang, 2012/03/13
- Re: [Qemu-devel] [RFC][PATCH 00/14 v9] introducing a new, dedicated memory dump mechanism,
Luiz Capitulino <=