Re: [Qemu-devel] [PATCH v4 05/11] hw/ac97: add support for volume control

[Marc-André Lureau]

On Tue, Mar 13, 2012 at 4:37 PM, malc <address@hidden> wrote:
> On Tue, 13 Mar 2012, Marc-Andr? Lureau wrote:
>
>> Combine output volume with Master and PCM registers values.
>> Use default values in mixer_reset ().
>> Set volume on post-load to update backend values.
>>
>> v4:
>> - fix some code style
>
> Don't think it fixes anything...
>
>>
>> Signed-off-by: Marc-Andr? Lureau <address@hidden>
>> ---
>>  hw/ac97.c |   80 
>> +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>>  1 files changed, 80 insertions(+), 0 deletions(-)
>>
>> diff --git a/hw/ac97.c b/hw/ac97.c
>> index f7866ed..f5ae637 100644
>> --- a/hw/ac97.c
>> +++ b/hw/ac97.c
>> @@ -436,6 +436,64 @@ static void reset_voices (AC97LinkState *s, uint8_t 
>> active[LAST_INDEX])
>>      AUD_set_active_in (s->voice_mc, active[MC_INDEX]);
>>  }
>>
>> +static void get_volume (uint16_t vol, uint16_t mask, int inverse,
>> +                        int *mute, uint8_t *lvol, uint8_t *rvol)
>> +{
>> +  *mute = (vol >> MUTE_SHIFT) & 1;
>> +  *rvol = (255 * (vol & mask)) / mask;
>> +  *lvol = (255 * ((vol >> 8) & mask)) / mask;
>> +  if (inverse) {
>> +    *rvol = 255 - *rvol;
>> +    *lvol = 255 - *lvol;
>
> Here.
>
> [..snip..]

checkpatch doesn't complain here, I only get 30 warnings:

WARNING: space prohibited between function name and open parenthesis '('

which seems to be the code style in audio/

thanks

-- 
Marc-André Lureau