[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [RfC PATCH] usb/vmstate: add parent dev path
From: |
Paolo Bonzini |
Subject: |
Re: [Qemu-devel] [RfC PATCH] usb/vmstate: add parent dev path |
Date: |
Tue, 13 Mar 2012 13:42:04 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:10.0.1) Gecko/20120216 Thunderbird/10.0.1 |
Il 13/03/2012 13:34, Gerd Hoffmann ha scritto:
> ... to make vmstate id string truely unique with multiple host
> controllers, i.e. move from "1/usb-ptr" to "0000:00:01.3/1/usb-ptr"
> (usb tabled connected to piix3 uhci).
>
> This is needed in case you have multiple USB busses in a virtual
> machine to make sure the section names are unique. Obviously this
> will break migration. I'm sitting on the patch for a while already,
> with the plan to sneak it in when we have a migration flag day anyway
> for the planned new & shiny migration format.
>
> It doesn't look like this is going to happen anytime soon. I'd like to
> have this fixed in the 1.1 release. Suggestions how to go forward?
Add a property to the hcd devices, and set it to false for compatibility
machines?
That is
- if (id) {
+ if (id && qdev_get_bit(hcd, "full-device-path")) {
BTW, your recently added serial.wakeup property uses a uint32... any
chance you could change it to a bit so that -global isa-serial.wakeup=on
works (nicer than =1 imho)?
Paolo