[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev
From: |
Lai Jiangshan |
Subject: |
Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev |
Date: |
Tue, 13 Mar 2012 17:32:15 +0800 |
User-agent: |
Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.9) Gecko/20100921 Fedora/3.1.4-1.fc14 Thunderbird/3.1.4 |
On 02/16/2012 08:51 PM, Anthony Liguori wrote:
> On 02/16/2012 06:01 AM, Jan Kiszka wrote:
>> On 2012-02-16 00:16, Igor Mammedov wrote:
>>> +static ICCBusDeviceInfo cpu_device_info = {
>>> + .qdev.name = "cpu-pc",
>>> + .qdev.size = sizeof(CPUPC),
>>> + .qdev.reset = cpu_device_reset,
>>> + .init = cpu_device_init,
>>> + .qdev.props = (Property[]) {
>>> + DEFINE_PROP_STRING("model", CPUPC, model),
>>
>> And how do you pass in feature flags? Or the core layout? Basically both
>> -cpu and -smp need to be expressible via multiple "-device cpu-x86,xxx"
>> (not "pc") commands.
>
> The approach that I'd recommend is:
>
> 1) convert CPU_COMMON_STATE to a structure named CPUCommonState,
> query/replace all references to members of CPU_COMMON_STATE appropriately.
>
Hi, All
I just tried this for several days, it will result a huge patch,
it is hard for human, any suggestion?
(I used Semantic patches script: http://coccinelle.lip6.fr/, it is still hard,
it still leaves huge part which needs manual conversion/fix)
I will take part in implementing cpu-hotplug future for qemu,
Could you give me some tips/suggestions? What approach should I take?
The main work of my "taking part in" is assisting for this community,
So you can assign some works/steps to me.
Thanks,
Lai
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev,
Lai Jiangshan <=
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Andreas Färber, 2012/03/13
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Lai Jiangshan, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Igor Mammedov, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Vasilis Liaskovitis, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Gleb Natapov, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Anthony Liguori, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Gleb Natapov, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Anthony Liguori, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Gleb Natapov, 2012/03/14
- Re: [Qemu-devel] [PATCH 2/7] Convert pc cpu to qdev, Anthony Liguori, 2012/03/14