Re: [Qemu-devel] [PATCH v3] use an uint64_t for the max_sz parameter in load_image_targphys

[Peter Maydell]

On 12 March 2012 16:47, Andreas Färber <address@hidden> wrote:
> A very non-intrusive solution for allowing large theoretical limits.
> I've skimmed through the callers and it looks fine.
>
> Reviewed-by: Andreas Färber <address@hidden>
>
> Independently David's off_t patch or a variation thereof would still be
> needed to make use of the enlarged limit, wouldn't it? Image sizes
> remain int here.

Yes. Also the arm_boot.c code is still passing things around in
int variables, which should be updated to use uint64_t. (The
arm_boot device tree code needs updating too, to check whether
the dtb is using 32 bit or 64 bit cell sizes for its RAM size).
I'm happy to put together a patch to do this at some point if
Mark doesn't already have one lined up.

-- PMM