qemu-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-devel] [PATCH] slirp: Fix compiler warning for w64


From: Stefan Weil
Subject: [Qemu-devel] [PATCH] slirp: Fix compiler warning for w64
Date: Sat, 10 Mar 2012 21:20:53 +0100

Casting a pointer to an integer value must use uintptr_t or intptr_t
(not long) for portable code. MinGW-w64 requires this because
sizeof(long) != sizeof(void *) for w64 hosts, so casting to long
raises a compiler warning.

I use uintptr_t instead of intptr_t because changing the sign does not
matter here and casting pointers to unsigned values seems more
reasonable (the unsigned value is a non negative offset.

Cc: Jan Kiszka <address@hidden>
Signed-off-by: Stefan Weil <address@hidden>
---
 slirp/cksum.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/slirp/cksum.c b/slirp/cksum.c
index e43867d..6328660 100644
--- a/slirp/cksum.c
+++ b/slirp/cksum.c
@@ -75,7 +75,7 @@ int cksum(struct mbuf *m, int len)
        /*
         * Force to even boundary.
         */
-       if ((1 & (long) w) && (mlen > 0)) {
+       if ((1 & (uintptr_t)w) && (mlen > 0)) {
                REDUCE;
                sum <<= 8;
                s_util.c[0] = *(uint8_t *)w;
-- 
1.7.9




reply via email to

[Prev in Thread] Current Thread [Next in Thread]