Re: [Qemu-devel] [PATCH 2/3] Redesign of pciinit.c

[Kevin O'Connor]

On Fri, Mar 09, 2012 at 07:51:06PM +1300, Alexey Korolev wrote:
> In this patch we introduce the pri_region_entry structure and
> significantly simplify the pci_bus structure. 
> Instead of arrays now we are using linked lists to account resources and
> assign memory bases. 
> 
> Since we modify the main structure of pciinit.c this is the minimum
> chunk of changes which could keep code workable. I mean further patch
> splitting is not possible as there are too many references to pci_bus
> members.

Thanks Alexey.  This is better than the previous patch, but I still
don't feel comfortable with the amount of change in a single patch.
I'm having a hard time reviewing the change.  I'd much prefer to see
one patch (or more) with just the data structure changes, and then one
patch (or more) with the change from the array based allocation system
to the list traversal allocation system.  (That is, it should be
possible to have all the linked lists in place while still using the
array system to do the allocations, and then in a separate patch
delete the arrays and convert over to list traversal.)

-Kevin