[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to d
From: |
Luiz Capitulino |
Subject: |
Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors |
Date: |
Fri, 9 Mar 2012 15:30:19 -0300 |
On Fri, 09 Mar 2012 19:20:56 +0100
Jan Kiszka <address@hidden> wrote:
> On 2012-03-09 19:13, Luiz Capitulino wrote:
> > The Monitor object is passed back and forth within the migration/savevm
> > code so that it can print errors and progress to the user.
> >
> > However, that approach assumes a HMP monitor, being completely invalid
> > in QMP.
> >
> > This commit drops almost every single usage of the Monitor object, all
> > monitor_printf() calls have been converted into DPRINTF() ones.
>
> I guess for most printfs, this is OK. But do you provide an alternative
> for the block migration progress output? I did not find anything on
> first glance. That is not a debugging feature.
Can't the info migrate command be used for that?
- [Qemu-devel] [PATCH v2 0/4] qapi: Convert migrate, Luiz Capitulino, 2012/03/09
- [Qemu-devel] [PATCH 1/4] QError: Introduce new errors for the migration command, Luiz Capitulino, 2012/03/09
- [Qemu-devel] [PATCH 2/4] Error: Introduce error_copy(), Luiz Capitulino, 2012/03/09
- [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Jan Kiszka, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors,
Luiz Capitulino <=
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Jan Kiszka, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Kevin Wolf, 2012/03/12
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Luiz Capitulino, 2012/03/12
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Eric Blake, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Anthony Liguori, 2012/03/09
- Re: [Qemu-devel] [PATCH 3/4] Purge migration of (almost) everything to do with monitors, Eric Blake, 2012/03/09